feat: add fixer function to eslint/rules/no-internal-require
#3364
Conversation
| @@ -83,9 +102,11 @@ function main( context ) { | |||
|
|
|||
| rule = { | |||
| 'meta': { | |||
| 'type': 'suggestion', | |||
There was a problem hiding this comment.
Heads up. Currently, the auto-fixing for suggestion type is not supported.
headlessNode
added
Feature
|
This is an interesting one. I am not sure whether we should autofix this or not. If someone is reaching into a package for a particular file, we should probably just error. Auto-fixing could just lead to other issues. |
|
@kgryte do we currently have anything calling the internals in the codebase? Also what other issues the auto-fixing could cause? |
@headlessNode Not that I am aware of.
If someone is reaching internally into a package and we autofix without their explicit opt-in, that could lead to unexpected behavior. E.g., if someone is expecting to load a data JSON file, but gets the main export of a package instead because we rewrote The reason why I recommend just raising a lint "error" is that we effectively force devs to confront the fact that they are reaching into a package when we generally don't want that. Devs could always explicitly disable the lint rule if they are insistent, but that would be an intentional choice. |
|
@kgryte Makes sense. Should I close this PR then? |
Description
This pull request:
fixerfunction toeslint/rules/no-internal-requireRelated Issues
No.
Questions
No.
Other
No.
Checklist
@stdlib-js/reviewers