-
-
Notifications
You must be signed in to change notification settings - Fork 578
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add C ndarray
implementation for blas/base/caxpy
#3456
Conversation
Coverage Report
The above coverage report was generated for the changes in this PR. |
Signed-off-by: Athan <kgryte@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this, @aman-095. IIRC, we also need to add documentation of the C APIs to the README, correct?
@kgryte, updated. |
@@ -207,7 +207,7 @@ The function accepts the following arguments: | |||
- **X**: `[in] double*` input array. | |||
- **strideX**: `[in] CBLAS_INT` index increment for `X`. | |||
- **Y**: `[inout] double*` output array. | |||
- **strideY**: `[in CBLAS_INT` index increment for `Y`. | |||
- **strideY**: `[in] CBLAS_INT` index increment for `Y`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing this. In the future, however, we'll want to open a separate PR in order to ensure a clean commit history and changelog.
Signed-off-by: Athan <kgryte@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this, @aman-095. LGTM.
Progresses #2039.
Description
This pull request adds C
ndarray
implementation forcaxpy
.Related Issues
This pull request:
Questions
No.
Other
No.
Checklist
@stdlib-js/reviewers