Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add C ndarray implementation for blas/base/caxpy #3456

Merged
merged 5 commits into from
Dec 12, 2024

Conversation

aman-095
Copy link
Member

Progresses #2039.

Description

What is the purpose of this pull request?

This pull request adds C ndarray implementation for caxpy.

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.


@stdlib-js/reviewers

@stdlib-bot stdlib-bot added the BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). label Dec 11, 2024
@stdlib-bot
Copy link
Contributor

stdlib-bot commented Dec 11, 2024

Coverage Report

Package Statements Branches Functions Lines
blas/base/caxpy $\color{red}429/431$
$\color{green}+99.54\%$
$\color{red}17/18$
$\color{green}+94.44\%$
$\color{green}4/4$
$\color{green}+100.00\%$
$\color{red}429/431$
$\color{green}+99.54\%$
blas/base/daxpy $\color{green}420/420$
$\color{green}+100.00\%$
$\color{green}30/30$
$\color{green}+100.00\%$
$\color{green}4/4$
$\color{green}+100.00\%$
$\color{green}420/420$
$\color{green}+100.00\%$

The above coverage report was generated for the changes in this PR.

@aman-095 aman-095 added Feature Issue or pull request for adding a new feature. C Issue involves or relates to C. labels Dec 11, 2024
@aman-095 aman-095 marked this pull request as ready for review December 12, 2024 01:27
@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Dec 12, 2024
Signed-off-by: Athan <kgryte@gmail.com>
Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this, @aman-095. IIRC, we also need to add documentation of the C APIs to the README, correct?

@kgryte kgryte added Needs Changes Pull request which needs changes before being merged. and removed Needs Review A pull request which needs code review. labels Dec 12, 2024
@aman-095
Copy link
Member Author

@kgryte, updated.

@kgryte kgryte removed the Needs Changes Pull request which needs changes before being merged. label Dec 12, 2024
@@ -207,7 +207,7 @@ The function accepts the following arguments:
- **X**: `[in] double*` input array.
- **strideX**: `[in] CBLAS_INT` index increment for `X`.
- **Y**: `[inout] double*` output array.
- **strideY**: `[in CBLAS_INT` index increment for `Y`.
- **strideY**: `[in] CBLAS_INT` index increment for `Y`.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this. In the future, however, we'll want to open a separate PR in order to ensure a clean commit history and changelog.

Signed-off-by: Athan <kgryte@gmail.com>
Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this, @aman-095. LGTM.

@kgryte kgryte merged commit b6ee443 into stdlib-js:develop Dec 12, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). C Issue involves or relates to C. Feature Issue or pull request for adding a new feature.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[RFC]: Add BLAS bindings and implementations for linear algebra (tracking issue)
3 participants