Skip to content

feat: add C implementation for stats/base/dists/bernoulli/skewness #3458

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 15 commits into from
Feb 5, 2025
Merged

feat: add C implementation for stats/base/dists/bernoulli/skewness #3458

merged 15 commits into from
Feb 5, 2025

Conversation

Neerajpathak07
Copy link
Member

Resolves #3420

Description

What is the purpose of this pull request?

This pull request:

  • adds C implementation for @stdlib/stats/base/dists/bernoulli/skewness

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@stdlib-js/reviewers

@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Dec 11, 2024
@stdlib-bot
Copy link
Contributor

stdlib-bot commented Dec 11, 2024 •
edited
Loading

Coverage Report

Package Statements Branches Functions Lines
stats/base/dists/bernoulli/skewness $\color{green}178/178$
$\color{green}+100.00\%$ 		$\color{green}13/13$
$\color{green}+100.00\%$ 		$\color{green}2/2$
$\color{green}+100.00\%$ 		$\color{green}178/178$
$\color{green}+100.00\%$

The above coverage report was generated for the changes in this PR.

kgryte
kgryte reviewed Dec 12, 2024
View reviewed changes
lib/node_modules/@stdlib/stats/base/dists/bernoulli/skewness/LICENSE Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this license file included here?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought since we were adding C implementations for the file and it could be referenced to create new files which is why i thought about adding them.

@kgryte kgryte added Feature Issue or pull request for adding a new feature. Statistics Issue or pull request related to statistical functionality. Needs Changes Pull request which needs changes before being merged. C Issue involves or relates to C. and removed Needs Review A pull request which needs code review. labels Dec 12, 2024
@Neerajpathak07
Copy link
Member Author

@kgryte I have done the changes from the code review and I apologize for the numerous errors I'll try to keep it minimum.
Thank you for the help!

@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Dec 12, 2024
@Planeshifter Planeshifter changed the title feat: add C implementation for @stdlib/stats/base/dists/bernoulli/skewness feat: add C implementation for stats/base/dists/bernoulli/skewness Dec 15, 2024
@Neerajpathak07 Neerajpathak07 marked this pull request as draft January 16, 2025 12:18
@stdlib-bot stdlib-bot removed the Needs Review A pull request which needs code review. label Jan 16, 2025
@Neerajpathak07
Copy link
Member Author

Neerajpathak07 commented Jan 16, 2025 •
edited
Loading

/stdlib help

@stdlib-bot stdlib-bot added the bot: In Progress Pull request is currently awaiting automation. label Jan 16, 2025
@stdlib-bot
Copy link
Contributor

@Neerajpathak07, slash command not recognized. Please use /stdlib help to view available commands.

@stdlib-bot stdlib-bot removed the bot: In Progress Pull request is currently awaiting automation. label Jan 16, 2025
@stdlib-bot
Copy link
Contributor

@Neerajpathak07, slash command not recognized. Please use /stdlib help to view available commands.

@stdlib-bot
Copy link
Contributor

@Neerajpathak07, available slash commands include:

  • /stdlib check-files - Check for required files.
  • /stdlib update-copyright-years - Update copyright header years.
  • /stdlib lint-autofix - Auto-fix lint errors.
  • /stdlib merge - Merge changes from develop branch into this PR.
  • /stdlib rebase - Rebase this PR on top of develop branch.

@Neerajpathak07 Neerajpathak07 marked this pull request as ready for review January 16, 2025 14:57
@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Jan 16, 2025
@Planeshifter
chore: apply suggestions from code review
afcebed 
Signed-off-by: Philipp Burckhardt <pburckhardt@outlook.com>
Planeshifter
Planeshifter approved these changes Feb 5, 2025
View reviewed changes
Copy link
Member

@Planeshifter Planeshifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will merge shortly after CI checks have passed.

@Planeshifter Planeshifter added the Ready To Merge A pull request which is ready to be merged. label Feb 5, 2025
@stdlib-bot stdlib-bot removed Needs Review A pull request which needs code review. Needs Changes Pull request which needs changes before being merged. labels Feb 5, 2025
@stdlib-bot
Copy link
Contributor

PR Commit Message

feat: add C implementation for `stats/base/dists/bernoulli/skewness`

PR-URL: https://github.com/stdlib-js/stdlib/pull/3458
Closes: https://github.com/stdlib-js/stdlib/issues/3420

Co-authored-by: Neeraj Pathak <neerajrpathak710@gmail.com>
Co-authored-by: Neerajpathak07 <neerajrpathak710@gmail.com>
Co-authored-by: Philipp Burckhardt <pburckhardt@outlook.com>
Co-authored-by: stdlib-bot <noreply@stdlib.io>
Reviewed-by: Philipp Burckhardt <pburckhardt@outlook.com>
Signed-off-by: Neeraj Pathak <neerajrpathak710@gmail.com>
Signed-off-by: Philipp Burckhardt <pburckhardt@outlook.com>

Please review the above commit message and make any necessary adjustments.

@Planeshifter Planeshifter merged commit ae4d64e into stdlib-js:develop Feb 5, 2025
29 checks passed
saurabhraghuvanshii pushed a commit to saurabhraghuvanshii/stdlib-gs that referenced this pull request Feb 11, 2025
@Neerajpathak07 @Planeshifter
@stdlib-bot @saurabhraghuvanshii
feat: add C implementation for stats/base/dists/bernoulli/skewness
8e007b4 
PR-URL: stdlib-js#3458
Closes: stdlib-js#3420

Co-authored-by: Philipp Burckhardt <pburckhardt@outlook.com>
Co-authored-by: stdlib-bot <noreply@stdlib.io>
Reviewed-by: Philipp Burckhardt <pburckhardt@outlook.com>
Signed-off-by: Neeraj Pathak <neerajrpathak710@gmail.com>
Signed-off-by: Philipp Burckhardt <pburckhardt@outlook.com>
ShabiShett07 pushed a commit to ShabiShett07/stdlib that referenced this pull request Feb 26, 2025
@Neerajpathak07 @Planeshifter
@stdlib-bot @ShabiShett07
feat: add C implementation for stats/base/dists/bernoulli/skewness
69ac61d 
PR-URL: stdlib-js#3458
Closes: stdlib-js#3420

Co-authored-by: Philipp Burckhardt <pburckhardt@outlook.com>
Co-authored-by: stdlib-bot <noreply@stdlib.io>
Reviewed-by: Philipp Burckhardt <pburckhardt@outlook.com>
Signed-off-by: Neeraj Pathak <neerajrpathak710@gmail.com>
Signed-off-by: Philipp Burckhardt <pburckhardt@outlook.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Planeshifter Planeshifter Planeshifter approved these changes

@kgryte kgryte Awaiting requested review from kgryte

Assignees
No one assigned
Labels
C Issue involves or relates to C. Feature Issue or pull request for adding a new feature. Ready To Merge A pull request which is ready to be merged. Statistics Issue or pull request related to statistical functionality.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[RFC]: Add C implementation for @stdlib/stats/base/dists/bernoulli/skewness
4 participants
@Neerajpathak07 @stdlib-bot @Planeshifter @kgryte