Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add C implementation for stats/base/dists/betaprime/logpdf #4059

Open
wants to merge 12 commits into
base: develop
Choose a base branch
from

Conversation

Neerajpathak07
Copy link
Contributor

Resolves #3440

Description

What is the purpose of this pull request?

This pull request:

  • adds C implementation for stats/base/dists/betaprime/logpdf

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.


@stdlib-js/reviewers

@stdlib-bot stdlib-bot added the Statistics Issue or pull request related to statistical functionality. label Dec 19, 2024
@stdlib-bot
Copy link
Contributor

stdlib-bot commented Dec 19, 2024

Coverage Report

Package Statements Branches Functions Lines
stats/base/dists/betaprime/logpdf $\color{green}342/342$
$\color{green}+100.00\%$
$\color{green}25/25$
$\color{green}+100.00\%$
$\color{green}4/4$
$\color{green}+100.00\%$
$\color{green}342/342$
$\color{green}+100.00\%$

The above coverage report was generated for the changes in this PR.

@Neerajpathak07 Neerajpathak07 marked this pull request as ready for review December 19, 2024 15:18
@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Dec 19, 2024
@Planeshifter Planeshifter added bot: Lint Autofix Pull request needing applicable lint errors to be automatically fixed. and removed bot: Lint Autofix Pull request needing applicable lint errors to be automatically fixed. labels Dec 20, 2024
@stdlib-bot stdlib-bot added bot: In Progress Pull request is currently awaiting automation. and removed bot: Lint Autofix Pull request needing applicable lint errors to be automatically fixed. labels Dec 20, 2024
@Planeshifter Planeshifter removed the bot: In Progress Pull request is currently awaiting automation. label Dec 20, 2024
@Neerajpathak07 Neerajpathak07 marked this pull request as draft January 16, 2025 14:57
@stdlib-bot stdlib-bot removed the Needs Review A pull request which needs code review. label Jan 16, 2025
@Neerajpathak07
Copy link
Contributor Author

/stdlib update-copyright-years

@stdlib-bot stdlib-bot added the bot: In Progress Pull request is currently awaiting automation. label Jan 17, 2025
@stdlib-bot stdlib-bot removed the bot: In Progress Pull request is currently awaiting automation. label Jan 17, 2025
@Neerajpathak07 Neerajpathak07 marked this pull request as ready for review January 17, 2025 18:17
@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Jan 17, 2025
@@ -198,7 +198,7 @@ Evaluates the natural logarithm of the [probability density function][pdf] (PDF)

```c
double y = stdlib_base_dists_betaprime_logpdf( 0.5, 1.0, 1.0 );
// returns ~-0.811
// returns ~-0.955
Copy link
Contributor Author

@Neerajpathak07 Neerajpathak07 Feb 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have made the change although the main.js file returns ~-0.811 for the same example. So, I do think the return value some where is incorrect. Let me know if I am thinking straight.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Review A pull request which needs code review. Statistics Issue or pull request related to statistical functionality.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[RFC]: Add C implementation for @stdlib/stats/base/dists/betaprime/logpdf
3 participants