Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add C implementation for stats/base/dists/laplace/stdev #4158

Merged
merged 2 commits into from
Dec 26, 2024

Conversation

vivekmaurya001
Copy link
Contributor

Resolves #3720 .

Description

  • adds C implementation for @stdlib/stats/base/dists/laplace/stdev along with relevant tests, benchmarks and examples

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.


@stdlib-js/reviewers

@stdlib-bot stdlib-bot added Statistics Issue or pull request related to statistical functionality. Needs Review A pull request which needs code review. labels Dec 23, 2024
@stdlib-bot
Copy link
Contributor

stdlib-bot commented Dec 23, 2024

Coverage Report

Package Statements Branches Functions Lines
stats/base/dists/laplace/stdev $\color{green}176/176$
$\color{green}+100.00\%$
$\color{green}9/9$
$\color{green}+100.00\%$
$\color{green}2/2$
$\color{green}+100.00\%$
$\color{green}176/176$
$\color{green}+100.00\%$

The above coverage report was generated for the changes in this PR.

Copy link
Member

@Planeshifter Planeshifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR looks good to me. 👍

@Planeshifter Planeshifter added the Ready To Merge A pull request which is ready to be merged. label Dec 26, 2024
@stdlib-bot stdlib-bot removed the Needs Review A pull request which needs code review. label Dec 26, 2024
@stdlib-bot
Copy link
Contributor

stdlib-bot commented Dec 26, 2024

PR Commit Message

feat: add C implementation for `stats/base/dists/laplace/stdev`  

PR-URL: https://github.com/stdlib-js/stdlib/pull/4158
Closes: https://github.com/stdlib-js/stdlib/issues/3720

Co-authored-by: Philipp Burckhardt <pburckhardt@outlook.com>
Reviewed-by: Philipp Burckhardt <pburckhardt@outlook.com>

Please review the above commit message and make any necessary adjustments.

…in.c

Signed-off-by: Philipp Burckhardt <pburckhardt@outlook.com>
@Planeshifter Planeshifter merged commit 15f2f56 into stdlib-js:develop Dec 26, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready To Merge A pull request which is ready to be merged. Statistics Issue or pull request related to statistical functionality.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[RFC]: Add C implementation for @stdlib/stats/base/dists/laplace/stdev
3 participants