Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add C implementation math/base/special/atan2f #4891

Draft
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

ShabiShett07
Copy link

Resolves #649.

Description

What is the purpose of this pull request?

This pull request:

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.


@stdlib-js/reviewers

@ShabiShett07 ShabiShett07 marked this pull request as ready for review January 25, 2025 17:56
@ShabiShett07 ShabiShett07 marked this pull request as draft January 25, 2025 17:57
@Neerajpathak07
Copy link
Contributor

duplicate of #3338

@ShabiShett07
Copy link
Author

duplicate of #3338

I didn't see that in the issue #649

@ShabiShett07
Copy link
Author

duplicate of #3338

But it has some errors right?

@Neerajpathak07
Copy link
Contributor

@ShabiShett07
Was made quite a while ago so must have been pretty up in the history.
Yeah, there are a few issues but it's just related to changing the fixtures which I'll do by tomorrow on priority!!

@Neerajpathak07
Copy link
Contributor

Neerajpathak07 commented Jan 25, 2025

@ShabiShett07 also your runner.jl had atan whereas we needed fixtures for atan2f which has 2 arguments in it whereas atan has a single argument. So, if they have been generated from there they might be incorrect

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[RFC]: Add C implementations to base special math functions (tracking issue)
2 participants