-
-
Notifications
You must be signed in to change notification settings - Fork 612
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bench: refactor random number generation in stats/base/dists/negative-binomial #5193
base: develop
Are you sure you want to change the base?
Conversation
Hello! Thank you for your contribution to stdlib. We noticed that the contributing guidelines acknowledgment is missing from your pull request. Here's what you need to do:
This acknowledgment confirms that you've read the guidelines, which include:
We can't review or accept contributions without this acknowledgment. Thank you for your understanding and cooperation. We look forward to reviewing your contribution! |
Coverage Report
The above coverage report was generated for the changes in this PR. |
Hello! Thank you for your contribution to stdlib. We noticed that the contributing guidelines acknowledgment is missing from your pull request. Here's what you need to do:
This acknowledgment confirms that you've read the guidelines, which include:
We can't review or accept contributions without this acknowledgment. Thank you for your understanding and cooperation. We look forward to reviewing your contribution! |
@anandkaranubc ready for review |
lib/node_modules/@stdlib/stats/base/dists/negative-binomial/cdf/benchmark/benchmark.js
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/stats/base/dists/negative-binomial/ctor/benchmark/benchmark.js
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/stats/base/dists/negative-binomial/ctor/benchmark/benchmark.js
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/stats/base/dists/negative-binomial/ctor/benchmark/benchmark.js
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/stats/base/dists/negative-binomial/ctor/benchmark/benchmark.js
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/stats/base/dists/negative-binomial/ctor/benchmark/benchmark.js
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/stats/base/dists/negative-binomial/logpmf/benchmark/benchmark.js
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/stats/base/dists/negative-binomial/mgf/benchmark/benchmark.js
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/stats/base/dists/negative-binomial/mgf/benchmark/benchmark.js
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/stats/base/dists/negative-binomial/pmf/benchmark/benchmark.js
Outdated
Show resolved
Hide resolved
@gkbishnoi07, I left some comments for you to review. Please ensure that the suggested changes are applied consistently throughout the PR, including areas where they were not explicitly mentioned but are necessary. |
e8ce64a
to
e23cfe3
Compare
@anandkaranubc please review |
Description
What is the purpose of this pull request?
This pull request:
stats/base/dists/negative-binomial
.randu()
withuniform()
for cleaner and more consistent code.Related Issues
Does this pull request have any related issues?
This pull request:
stats/base/dists/negative-binomial
#4980Questions
Any questions for reviewers of this pull request?
No.
Other
Any other information relevant to this pull request?
No.
Checklist
Please ensure the following tasks are completed before submitting this pull request.