-
-
Notifications
You must be signed in to change notification settings - Fork 579
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add native addon to ceiln
and cceiln
#988
Conversation
lib/node_modules/@stdlib/math/base/special/cceiln/benchmark/benchmark.native.js
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/math/base/special/cceiln/docs/types/test.ts
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/math/base/special/cceiln/examples/index.js
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/math/base/special/cceiln/examples/index.js
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/math/base/special/cceiln/manifest.json
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/math/base/special/cceiln/test/test.native.js
Outdated
Show resolved
Hide resolved
Coverage Report
The above coverage report was generated for the changes in this PR. |
Coverage Report
The above coverage report was generated for the changes in this PR. |
Coverage Report
The above coverage report was generated for the changes in this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@steff456 Looks like we still need to make some changes in the C implementation. Left comments. This should all be straightforward. Once addressed, I think this should be ready to merge.
Coverage Report
The above coverage report was generated for the changes in this PR. |
Coverage Report
The above coverage report was generated for the changes in this PR. |
Coverage Report
The above coverage report was generated for the changes in this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Will merge once CI passes.
Coverage Report
The above coverage report was generated for the changes in this PR. |
Coverage Report
The above coverage report was generated for the changes in this PR. |
Coverage Report
The above coverage report was generated for the changes in this PR. |
Part of https://github.com/stdlib-js/todo/issues/1454
Description
This pull request:
For
ceiln
API:For
cceiln
API:Related Issues
This pull request:
Questions
No.
Other
No.
Checklist
@stdlib-js/reviewers