Convert bash to POSIX sh, polish things #6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey there,
First off, thank you so very much for your efforts on putting this together.
I'd just like to add a small contribution by transforming some things in the
script, mostly to improve legibility and portability, to a degree. With the
latter kind of improvement, hopefully, by default, one gets better performance
out of it.
By opting for writing using POSIX shell constructs only, we strip away the
adages bash brings into the fold while still keeping the same functionality,
making it more portable, and, in systems where
/bin/sh
links to a shell otherthan
bash
(saydash
), we typically get better performance right off the batdue to the lighter nature of shells such as
dash
.Hopefully this PR can introduce some discussion as well, the changes are...
quite daunting at first, but from the little testing I've done, things work just
fine!
Cheers.