Refine logic to detect whether link exists already #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Chrome/Safari seem to wait until the link tag has finished loading to add it to `document.styleSheets` and that causes the slim loader to duplicate the link tag. Using `document.querySelectorAll` works fine in the three browsers Closes #64
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Chrome/Safari seem to wait until the link tag has finished loading to
add it to
document.styleSheetsand that causes the slim loader toduplicate the link tag.
Using
document.querySelectorAllworks fine in the three browsersI didn't have a failing test b/c I'd need to run it in chrome/safari, not sure
if that's worth doing.
Closes #64