Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gzip needs to depend on a gzip accept header! #3

Closed
frank-dspeed opened this issue Jul 21, 2017 · 2 comments
Closed

gzip needs to depend on a gzip accept header! #3

frank-dspeed opened this issue Jul 21, 2017 · 2 comments
Labels

Comments

@frank-dspeed
Copy link

frank-dspeed commented Jul 21, 2017

Not all browser support gzip you need to check the req accept header for that.
https://github.com/stealjs/steal-push/blob/master/lib/index.js#L70,L76

sorry that the link don't marks the indipendent lines we are working on that as soon as github mergs isaccs pulls this will show up right :) isaacs/github#453 isaacs/github#9

@matthewp
Copy link
Member

Ah, good point, thanks.

@matthewp matthewp added the bug label Jul 25, 2017
@frank-dspeed
Copy link
Author

frank-dspeed commented Jul 25, 2017

@matthewp no need to thanks for that you already payed back as i don't knowed about the .push prototype :) i setted push headers directly on the res :) but i have a little extra tip for you so that i added value you should only use the req object it holds a response prototype normaly

this way your more compatible to more nodejs server side frameworks:
for example: http://dietjs.com/ wich only uses one property that we call signal

matthewp added a commit that referenced this issue Jul 26, 2017
Is provided and gzip is an option. Closes #3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants