Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

live-reload - Connections abruptly ending causes server to stop working #912

Closed
matthewp opened this issue Jan 4, 2018 · 1 comment · Fixed by #913
Closed

live-reload - Connections abruptly ending causes server to stop working #912

matthewp opened this issue Jan 4, 2018 · 1 comment · Fixed by #913
Assignees
@matthewp
Labels
bug p0

Comments

@matthewp
Copy link
Member

matthewp commented Jan 4, 2018

Not sure the root cause of why this started happening. It could either be a change in browser behavior or a change in Node or ws behavior. Either way, if we handle the error event on sockets, we can detect and safely ignore when this occurs. First reported in donejs/donejs#1064.
@matthewp matthewp mentioned this issue Jan 4, 2018
Closed
5 tasks
@matthewp matthewp added the bug label Jan 4, 2018
@matthewp matthewp self-assigned this Jan 4, 2018
@matthewp matthewp added the p0 label Jan 4, 2018
@matthewp
Copy link
Member Author

matthewp commented Jan 4, 2018

Root cause is a change in ws: websockets/ws#1256 (comment)

matthewp added a commit that referenced this issue Jan 4, 2018
@matthewp
Handle errors from uncleaned disconnected connections
ed19f24 
Chrome 63 no longer closes its websocket connection cleanly, which
causes an error on the socket in the server.

This makes sure that we handle the error. Fixes #912
@matthewp matthewp mentioned this issue Jan 4, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@matthewp matthewp

Labels
bug p0
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Handle errors from uncleaned disconnected connections stealjs/steal-tools
1 participant
@matthewp