Adds test showing ES6 circular dependencies working with Babel #535

matthewp · 2016-10-26T18:53:20Z

Closes #382

coveralls · 2016-10-26T19:03:55Z

Coverage remained the same at 92.25% when pulling a3e7b98 on circ into ad6cac4 on major.

pYr0x · 2016-10-26T20:16:07Z

test/circular/main.js

+import { getBar } from './foo';
+import { getFoo } from './bar';
+
+// true in dev, false in production


What do you mean with that comment?
In the multibuild_test you check against true in prod.html

Comment was old, when this was breaking it was true in dev and false in prod. It's working now, just forgot to remove the comment.

Adds test showing ES6 circular dependencies working with Babel

a3e7b98

Closes #382

matthewp added the in progress label Oct 26, 2016

matthewp merged commit 3e47575 into major Oct 26, 2016

matthewp deleted the circ branch October 26, 2016 19:09

matthewp removed the in progress label Oct 26, 2016

matthewp mentioned this pull request Oct 26, 2016

circular dependencies not resolving correctly in production build #382

Closed

pYr0x reviewed Oct 26, 2016

View reviewed changes

Provide feedback