Cleanup API in README #127
Conversation
| } | ||
| export function exec(command: String, args: Array<string> = [], options: Object) | ||
| export function execNode(filePath: String, args: Array<string> = [], options: Object) | ||
| export function parse(data: String, regex: String, options: Object = {baseReduction: 1, flags: ""}) |
There was a problem hiding this comment.
baseReduction isn't used in the code anywhere, where did this come from?
There was a problem hiding this comment.
Also shouldn't this show that by default (forced) the g flag is used?
There was a problem hiding this comment.
It was used to convert Line 5 to Line 4 to make it Atom's 0-based range. Done
steelbrain
force-pushed
the
steelbrain/cleanup-readme
branch
from
fae6050 to
3784a6a
Compare
| static tempFile<T>(fileName:String, fileContents:String, Callback:Function<T>):Promise<T> | ||
| static tempFiles<T>(filesNames:Array<{name: String, contents: String}>, callback:Function<T>):Promise<T> | ||
| } | ||
| export function exec(command: String, args: Array<string> = [], options: Object) |
There was a problem hiding this comment.
Should the return type be specified on these functions that return something?
There was a problem hiding this comment.
Added return types for exec, execNode and parse
steelbrain
force-pushed
the
steelbrain/cleanup-readme
branch
from
3784a6a to
297eef6
Compare
|
Note: CI build is failing because of babel/babel-eslint#267 |
| export function execNode(filePath: String, args: Array<string> = [], options: Object): Promise | ||
| export function parse(data: String, regex: String, options: Object = {flags: 'g'}): Array<Linter$Message> | ||
| export function rangeFromLineNumber(textEditor: TextEditor, lineNumber: Number = 0, colStart: Number = <firstTextColumn>):Array | ||
| export function find(directory:String, names: String | Array<string>): ?String |
There was a problem hiding this comment.
directory:String -> directory: String
There was a problem hiding this comment.
There should be a linter that does that, I had previously just copy/pasted, I'll tweak them all now
steelbrain
force-pushed
the
steelbrain/cleanup-readme
branch
from
297eef6 to
0027cb5
Compare
|
I think that last batch of comments is the last thing I see. |
|
All comments taken care of |
steelbrain
force-pushed
the
steelbrain/cleanup-readme
branch
from
375989e to
0027cb5
Compare
Just like the title says