Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TypeScript #88

Merged
merged 25 commits into from
Jun 15, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
25 commits
Select commit Hold shift + click to select a range
ba90e4d
chore: add typescript scripts and configs
aminya Jun 15, 2021
6659d2b
feat: convert to TypeScript
aminya Jun 15, 2021
b6af86e
chore: rename TextEditorMarker to DisplayMarker
aminya Jun 15, 2021
027405d
chore: cast type of visibleRange
aminya Jun 15, 2021
2cfca6c
chore: remove decls folder
aminya Jun 15, 2021
5bc8c75
chore: fix the types of promises in ProviderHighlight.trigger
aminya Jun 15, 2021
7418527
chore: fix the type of ListView.element
aminya Jun 15, 2021
8896311
chore: fix the types of promises in ProvidersList.trigger
aminya Jun 15, 2021
c23c469
test: test the built files
aminya Jun 15, 2021
b6c4ba5
chore: add CommandEventExtended type
aminya Jun 15, 2021
c695b21
fix: do not modify the original scopes
aminya Jun 15, 2021
7d2c200
fix: remove unused intention parameter
aminya Jun 15, 2021
3a574c6
chore: fix the type of className in processListItems
aminya Jun 15, 2021
1f26d71
chore: fix the type of detail parameter in showError
aminya Jun 15, 2021
fedb76e
fix: fix making a providers array
aminya Jun 15, 2021
a142cf9
chore: fix the type of markers in ProvidersHighlight.paint
aminya Jun 15, 2021
a157a6d
fix: use the correct `this` in stoppingEvent
aminya Jun 15, 2021
ac27f13
fix: export entry functions directly
aminya Jun 15, 2021
9edd514
chore: make tsconfig strict
aminya Jun 15, 2021
e78a942
chore: add build-commit
aminya Jun 15, 2021
e4d3320
fix: use includes instead of indexOf
aminya Jun 15, 2021
507ffe9
chore: mark sb_intentions_class as optional
aminya Jun 15, 2021
bec7136
chore: add ShowListEvent type
aminya Jun 15, 2021
80a855e
ci: retry the tests in case they fail
aminya Jun 15, 2021
a53b256
fix: update disposable-event
aminya Jun 15, 2021
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .eslintrc.json
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
{
"extends": "eslint-config-atomic",
"ignorePatterns": ["dist/", "node_modules/", "decls/"]
"ignorePatterns": ["dist/", "node_modules/"]
}
9 changes: 0 additions & 9 deletions .flowconfig

This file was deleted.

12 changes: 7 additions & 5 deletions .github/workflows/CI.yml
Original file line number Diff line number Diff line change
Expand Up @@ -27,8 +27,13 @@ jobs:
- name: Install dependencies
run: apm install

- name: Run tests 👩🏾‍💻
run: npm run test
# The tests are flaky
- name: Run tests
uses: nick-invision/retry@v2
with:
timeout_minutes: 1
max_attempts: 3
command: npm run test

Lint:
if: "!contains(github.event.head_commit.message, '[skip ci]') && !contains(github.event.head_commit.message, 'Prepare ')"
Expand All @@ -53,8 +58,5 @@ jobs:
- name: Format ✨
run: pnpm run test.format

- name: Flow
run: pnpm run test.flow

- name: Lint
run: pnpm run test.lint
1 change: 1 addition & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -2,3 +2,4 @@
.DS_Store
npm-debug.log
node_modules
dist
18 changes: 0 additions & 18 deletions decls/atom.js

This file was deleted.

13 changes: 0 additions & 13 deletions decls/others.js

This file was deleted.

Loading