Setting to prevent panel activation on startup #660
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This setting determines whether or not a new panel is automatically created when the editor starts
aminya
reviewed
Sep 30, 2021
aminya
reviewed
Sep 30, 2021
| await this.activate() | ||
| } | ||
|
|
||
| this.initialized = true |
There was a problem hiding this comment.
This means that the linter is initialized anyway.
There was a problem hiding this comment.
True, but not until after this.activate() has run. I found that the panel is activated twice really close together on startup because this.activate() calls this.refresh(), which then also calls this.activate(). The code added in lib/panel/index.ts on line 131 prevents this.refresh() from doing anything until this.initialized has been set, so the duplicate activation doesn't happen.
…el-activation-on-startup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This simply adds another setting called
Create Panel On Startthat, if checked, prevents the linter UI panel from being created automatically when Atom starts up or is refreshed.The motivation behind this setting is to help keep the Atom panel clean when it is being used by other extensions. In my particular case, I use X Terminal quite a bit, and when I have multiple terminals open and restart Atom, I don't want the linter UI adding its own tab among my X Terminal tabs.