Patch that makes your application readable to crawlers if you have '!' ... #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
|
Thanks Leonardo, I heard from some other folks from around here that this small patch has helped them, I hope that steeve finds the time to merge it into master. |
|
Hey Oleg! Anyway, it's going in :) |
steeve
added a commit
that referenced
this pull request
Oct 30, 2013
Patch that makes your application readable to crawlers if you have '!' ...
|
Merged, thank you very much :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, I had an issue with FB graph API and other crawlers.
It seems that the crawlers encode the URL if there is a '!' sign in your application URL, which stops your library from working correctly.
I've added decodeURIComponent function at line 51 of the angular-seo-server.js file, which prevents this behavior from happening, and doesn't affect anything else.
I've run your tests, and also did some manual testing with my applicantion and everything seems fine.
I hope that you'll be able to receive this modest contribution