Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added additional docs for htmlReady() function #13

Merged
merged 3 commits into from
Feb 19, 2015

Conversation

BeOleg
Copy link
Contributor

@BeOleg BeOleg commented Oct 30, 2013

With a suggestion on how to implement the call of this function within the config function of the Angular app, this way it automatically applies to the entire application without a need for specific implementation in every view, and without breaking your head with counting ajax requests or anything else if you're running a heave AJAX application such as I do.

…lReady() function on the config level, without having to implement it for each controller seperately
@steeve
Copy link
Owner

steeve commented Oct 30, 2013

Ah! Didn't see that. Let me take a look.

@steeve
Copy link
Owner

steeve commented Oct 30, 2013

While it's a nice addition, I guess we should leave the developer the burden of knowing when its view is finally rendered.
We don't want to create corner cases here.

@BeOleg
Copy link
Contributor Author

BeOleg commented Oct 30, 2013

You are probably right.
It worked fine for me, but who knows what other setups other developers are
using.

I guess then I'll bring back the timeout outside of the removed event,
since the call to callPhantom() now happens directly, what do you think?

On Wed, Oct 30, 2013 at 7:17 PM, Steeve Morin notifications@github.comwrote:

While it's a nice addition, I guess we should leave the developer the
burden of knowing when its view is finally rendered.
We don't want to create corner cases here.


Reply to this email directly or view it on GitHubhttps://github.com//pull/13#issuecomment-27414630
.

@steeve
Copy link
Owner

steeve commented Oct 30, 2013

That said, it's a neat trick, so I'm for documenting it.
However, can you specify this is a recipe, and not a size fits all solution ?

@BeOleg
Copy link
Contributor Author

BeOleg commented Oct 30, 2013

There we go, I've added one commit to each of my pull requests, please take
a look at those whenever you have the time, and tell me if there are any
other changes required

On Wed, Oct 30, 2013 at 7:21 PM, Steeve Morin notifications@github.comwrote:

That said, it's a neat trick, so I'm for documenting it.
However, can you specify this is a recipe, and not a size fits all
solution ?


Reply to this email directly or view it on GitHubhttps://github.com//pull/13#issuecomment-27415055
.

steeve added a commit that referenced this pull request Feb 19, 2015
Added additional docs for htmlReady() function
@steeve steeve merged commit d6b50c5 into steeve:master Feb 19, 2015
Copy link

@chadf1472 chadf1472 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

l

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants