Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: improve button docs with another link option #127

Merged

Conversation

FelipeEmos
Copy link
Contributor

Hi!

Thanks for the great work! Here's a PR improving the docs for the Button by adding another way of creating links, which may be more convenient for some people. Since this is an already built into Kobalte, it's a no brainer 😉

I based the new text in the shadcn docs, which has pretty much the same alternative Link option ( by using the asChild prop )

Copy link

changeset-bot bot commented Aug 15, 2024

⚠️ No Changeset found

Latest commit: ee787b4

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Aug 15, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
solid-ui-components ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 15, 2024 2:57am

@stefan-karger
Copy link
Owner

Thanks for your contribution! :)
Improvements to the docs are more than welcome :)

@stefan-karger stefan-karger merged commit 0199f25 into stefan-karger:main Aug 26, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants