Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unwrap gymnasium Env before accessing mobile-env attributes #59

Merged
merged 5 commits into from
Nov 18, 2024

Conversation

stefanbschneider
Copy link
Owner

@stefanbschneider stefanbschneider commented Nov 17, 2024

Related to #57

Unwrap env before accessing mobile-env-specific attributes. Update notebooks and docs.

Bump to mobile-env 2.1.


Still, after this PR, neither Ray nor SB3 can run with gymnasium 1:

  • SB3 just doesn't support it yet (as of v2.3.2)
  • Ray RLlib does support gym 1 starting with Ray 2.39, but there are still issues with the action/observation spaces that I couldn't fix yet (and where I wonder if they are a bug in Ray).

In a later PR, I'll checker newer versions of both SB3 and Ray and see if they run with gymnasium 1.0.

Seems like the latest sb3 2.3.2 does not yet support gymnasium 1.0.0 --> shouldn't require it for mobile-env then
@stefanbschneider stefanbschneider changed the title Support gymnasium 1.0.0 Unwrap gymnasium Env before accessing mobile-env attributes Nov 17, 2024
@stefanbschneider stefanbschneider marked this pull request as draft November 17, 2024 18:33
@stefanbschneider stefanbschneider marked this pull request as ready for review November 17, 2024 21:13
@stefanbschneider stefanbschneider merged commit c24f31d into main Nov 18, 2024
13 checks passed
@stefanbschneider stefanbschneider deleted the issue57 branch November 18, 2024 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant