Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Stefan,
This is a follow-up on #30. We have been preparing a new release of ggplot2 and during a reverse dependency check it became apparent that the prospective ggplot2 3.5.0 would break lemon. As the person responsible for the breakage, I thought I might help out with a PR.
Since implementing #30 we have slightly changed the mechanism in
panel_guides_grob()
. This PR reflects these changes in the one used by lemon. To test the code changes with the release candidate, you can install it with the code below:The release of ggplot2 3.5.0 is scheduled at the end of January / early Februari. The progress can be tracked in tidyverse/ggplot2#5588.