Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update panel_guides_grob() #33

Merged
merged 1 commit into from
Feb 7, 2024
Merged

update panel_guides_grob() #33

merged 1 commit into from
Feb 7, 2024

Conversation

teunbrand
Copy link
Contributor

Hi Stefan,

This is a follow-up on #30. We have been preparing a new release of ggplot2 and during a reverse dependency check it became apparent that the prospective ggplot2 3.5.0 would break lemon. As the person responsible for the breakage, I thought I might help out with a PR.

Since implementing #30 we have slightly changed the mechanism in panel_guides_grob(). This PR reflects these changes in the one used by lemon. To test the code changes with the release candidate, you can install it with the code below:

remotes::install_github("tidyverse/ggplot2", ref = remotes::github_pull("5592"))

The release of ggplot2 3.5.0 is scheduled at the end of January / early Februari. The progress can be tracked in tidyverse/ggplot2#5588.

@teunbrand
Copy link
Contributor Author

This is just a friendly reminder that the release of ggplot2 is scheduled soon.

@stefanedwards
Copy link
Owner

stefanedwards commented Feb 7, 2024 via email

@stefanedwards stefanedwards changed the base branch from master to ggplot2_3.5.0 February 7, 2024 15:17
@stefanedwards stefanedwards merged commit 1d586ba into stefanedwards:ggplot2_3.5.0 Feb 7, 2024
@teunbrand
Copy link
Contributor Author

Great thanks!

@teunbrand teunbrand deleted the ggplot2_3.5.0 branch February 7, 2024 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants