Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Armenian country and subdivision names #68

Closed
t1gr4n opened this issue Jun 17, 2022 · 9 comments
Closed

Armenian country and subdivision names #68

t1gr4n opened this issue Jun 17, 2022 · 9 comments

Comments

@t1gr4n
Copy link

t1gr4n commented Jun 17, 2022

Hi!
I'd like to contribute the Armenian translations for country and also (some) subdivision names. In #60 you mention you do not take any direct contributions for country names but rather fetching them from Wikipedia. If that's the case, this is the page that can be used for it https://hy.wikipedia.org/wiki/ISO_3166-1. Please suggest if the format is not suitable, or otherwise if the direct PR with translation is needed.
Also, any idea how to maintain subdivision name translations?

@stefangabos
Copy link
Owner

Would be nice to use the same format as used for the other languages. If that is too much of a trouble I will adapt my script to fetch data from the page you indicated. Still, it has to have the exact same number of codes/countries as the ones that we already have

As for the subdivisions, here is how to contribute

@t1gr4n
Copy link
Author

t1gr4n commented Jun 17, 2022

Let me look into changing the page format, that would be better.

@t1gr4n
Copy link
Author

t1gr4n commented Jun 19, 2022

@stefangabos , I have updated the content at https://hy.wikipedia.org/wiki/ISO_3166-1 to the table format and added the missing entries. Please let me know if any further changes are needed.
As per the subdivisions, the mentioned link only describes how to contribute to the list of the subdivisions, but I'm having hard time to figure out how to provide translations. The current format for subdivisions does not seem to support multiple languages, any plans for that?
There are valid use cases for having subdivisions in multiple languages I'd be happy to help out on that, please suggest.

@stefangabos
Copy link
Owner

great job with that page! I am going to work on adding it later on today.
as for the subdivisions page, as per description, you are supposed to add/edit entries in the csv file and create a pull-request. the ISO-3166-2 standard has english names only; see here

@stefangabos
Copy link
Owner

...but i am open on extending the data for the subdivisions but i don't have a good resource for all the data, in all the supported languages

@stefangabos
Copy link
Owner

I found one single issue

Turkey is missing

Turkey TR TUR 792 ISO 3166-2:TR

@stefangabos
Copy link
Owner

...nevermind, it's there it's just that my script didn't pick it up for some reason, sorry

@stefangabos
Copy link
Owner

i've added the Armenian language and published a new version
thanks a lot for your work!

@t1gr4n
Copy link
Author

t1gr4n commented Jun 19, 2022

Thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants