-
-
Notifications
You must be signed in to change notification settings - Fork 378
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix simplified Chinese and traditional Chinese mix #32
Conversation
I saw your comment in another pull request, you have a script, but I don't know if your script get data from wiki code or the webpage. The Chinese Wikipedia can auto convert between traditional and simplified Chinese, so the country names in wiki code may be mixed.(and it's not allowed to change between them.) If your script get data from webpage, that will be great, you should just change the target URL to a concerted page. If you get data from wiki code, a manual conversion will be needed. |
This is the link from where I am taking country names. Obviously, I take the country names by parsing the HTML code in the page, but whatever you see is the same as what there is in the page's code. |
Can you please give me a link to that page set up so that it shows what I need to parse? |
Apparently what I see when I am accessing the page is in - according to Google Translate - Chinese (Traditional) |
Additionally, switching via Google Translate from traditional to simplified Chinese makes no difference in country names - at least that is how it seems to me |
Simplified Chinese: |
done. do i have to include other variations of the Chinese language? Like zh-tw, zh-hk, zh-mo, zh-my, etc. ? if so, which ones should I add? thank you for helping! |
I think it's a good idea to add zh-tw and zh-hk version, and no need to add other variants. zh-mo is almost same as zh-hk. zh-my and zh-sg are almost same as zh-cn. |
btw, Would you like to add svg version of flags? You can get filenames of them from the html, and find them in wikimedia commons. |
i have reprocessed the wikipedia page and updated the country name for the one you changed. |
Thank you for this pleasant discussion and for your excellent project. |
No description provided.