Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Traditional Chinese translation #35

Closed
wants to merge 3 commits into from

Conversation

hirakujira
Copy link

I added Traditional Chinese (zh_TW) translation.

@hirakujira
Copy link
Author

It's based on https://zh.wikipedia.org/wiki/ISO_3166-1 but has minor changes because some names are not updated in this list.

For example: NL (Netherlands) announced "尼德蘭" should be the official Chinese translation since 2020 but wikipedia still shows "荷蘭", which means "Holland".

Also, TW (Taiwan, Province of China) translated to "台灣", because the translation of zh_TW is for people in Taiwan and we don't agree that Taiwan is a province of China.

@stefangabos
Copy link
Owner

Since the lists are compiled automatically from Wikipedia, I can't take pull requests.
But, what I did was to add https://zh.wikipedia.org/wiki/ISO_3166-1 to my lists of sources to fetch and I added the changes you requested for the Netherlands and for Taiwan.

Please have a look - it's in the data/zh folder. I would appreciateit if you'd change the naming for Netherlands on the Wikipedia page, so I don't have to always overwrite it.

Thank you!

@stefangabos
Copy link
Owner

I added it also to http://stefangabos.github.io/world_countries/

@hirakujira
Copy link
Author

hirakujira commented Aug 2, 2020

Hello,
I'm sorry that I made a mistake, Netherland can be pulled directly from Wikipedia. No need modifications. The only thing that need to be changed manually is Taiwan.

And also, the data you fetched seems contains Simplified Chinese because Wikipedia shows Traditional Chinese on my computer automatically, but not on your side

Please fetch this URL instead: https://zh.wikipedia.org/zh-tw/ISO_3166-1, I'm sorry for the inconvenience and very appreciated for your patience.

@stefangabos
Copy link
Owner

Don't worry about it - thank you for your help!
I updated the lists, please have a look

@hirakujira
Copy link
Author

Yes, it's perfect now, thanks for your help!

@hirakujira hirakujira closed this Aug 2, 2020
@stefangabos
Copy link
Owner

I published a new release - 1.1.1, and it is now available via npm or from here
Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants