Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Moved the metadata into setup.cfg. #47

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Moved the metadata into setup.cfg. #47

wants to merge 1 commit into from

Conversation

KOLANICH
Copy link

@KOLANICH KOLANICH commented Jan 2, 2022

Added pyproject.toml.
Version is now fetched and populated automatically from git tags using setuptools_scm.
Metadata stored in source files is fetched using read_version.
Got rid of raw scripts, using console_scripts entry point since now.

@coveralls
Copy link

coveralls commented Jan 2, 2022 •
edited
Loading

Coverage Status

Coverage decreased (-24.5%) to 75.472% when pulling 70cdcc0 on KOLANICH-libs:setup.cfg into 896102d on stefankoegl:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-96.2%) to 3.797% when pulling a5bab9f on KOLANICH-libs:setup.cfg into 896102d on stefankoegl:master.

@stefankoegl
Copy link
Owner

Thanks for your contribution!

Added pyproject.toml. Version is now fetched and populated automatically from git tags using setuptools_scm.

Can you please explain how that's supposed to work? The tests are failing due to the missing (not yet generated?) version.py.

@KOLANICH KOLANICH force-pushed the setup.cfg branch 2 times, most recently from e37c07f to 4c6feea Compare January 16, 2022 20:51
@KOLANICH
Copy link
Author

KOLANICH commented Jan 16, 2022 •
edited
Loading

Can you please explain how that's supposed to work?

setuptools_scm is a setultools plugin (in fact poetry_core also can invoke them). It is executed on stage of package building. It detects version control system, fetches the latest tag looking like a version and populates a version from it.

The tests are failing due to the missing (not yet generated?) version.py.

You used to have version hardcoded into package, because fetching it using pkg_resources is terribly slow. Fortunately setuptools_scm has a feature to generate such files. But package building is required to generate the file.

I have added it.

Also I saw that the test for 2.7 fails in the testing module. IDK why it fails (I have not touched that file in this PR), but given that PSF itself has dropped 2.7 and that 3.4 works well on Windows XP, so ones wanting to use your module on ancient machines can just use python 3 (also a no longer supported version, but still 3 branch of python), I just disabled CI for 2.7.

The decrease in coverage is because the code that has not been tested (but that has been executed) is no longer executed, the tests succeed though.

@KOLANICH
Moved the metadata into setup.cfg.
70cdcc0 
Added `pyproject.toml`.
Version is now fetched and populated automatically from git tags using `setuptools_scm`.
Metadata stored in source files is fetched using `read_version`.
Got rid of raw scripts, using `console_scripts` entry point since now.
Dropped 2.7 out of Travis CI due to `File "tests.py", line 334, in <module> m = __import__(module, fromlist=[module]) TypeError: Item in "from list'' must be str, not unicode` error.
@stefankoegl stefankoegl mentioned this pull request Jan 18, 2022
Open
@stefankoegl
Copy link
Owner

I've opened the discussion about dropping Python 2.7 support at #48.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@KOLANICH @coveralls @stefankoegl