Sorting tests #418
Merged
Sorting tests #418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- a consistent ordering (id) makes test_sort_by_ancestry more consistent arrange was originally using sort_by_ancestry sort(ancestry) acts differently in different operating systems due to the locale used for sorting unicode strings. Now that the sort is only sorting the id, the edge cases are no longer necessary. - ordering the original records has been moved from ruby to sql - extracted test helper build methods into a separate method
Change the tests so they don't match a simple id ordering
introduce a few that fail, so the fixing methods can call them out
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
extracted from #415
Introduce sorting tests (with some skipped) so we can state the problems and see them getting fixed as we merge PRs