Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update Ancestry writers #633

Merged
merged 2 commits into from
Mar 14, 2023
Merged

update Ancestry writers #633

merged 2 commits into from
Mar 14, 2023

Conversation

kbrock
Copy link
Collaborator

@kbrock kbrock commented Mar 14, 2023

extracted from #600

These are now non-editable class level variables:

If this breaks in developer code try the class variable e.g.: self.class.ancestry_column

@kbrock kbrock force-pushed the ancestry_writers branch from d66f2f1 to bed3d7f Compare March 14, 2023 19:37
@kbrock
Copy link
Collaborator Author

kbrock commented Mar 14, 2023 •
edited
Loading

update:

  • found one more spot accessing instance variable ancestry_base_class
  • fixed sql strategy accessors

@kbrock kbrock force-pushed the ancestry_writers branch from bed3d7f to 0c0240a Compare March 14, 2023 19:44
@kbrock kbrock merged commit a394946 into stefankroes:master Mar 14, 2023
@kbrock kbrock deleted the ancestry_writers branch March 14, 2023 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kbrock @kshnurov