-
Notifications
You must be signed in to change notification settings - Fork 230
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds naming conventions documentation #223
Adds naming conventions documentation #223
Conversation
{% endraw %} | ||
{% endhighlight %} | ||
|
||
This is great. However, in Ember App Kit we use a Resolver to alleviate the issue of namespacing your views, controllers, models, etc... So the above example would not work. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
May I suggest a slight change in copy? "Ember App Kit uses a Resolver to alleviate the issue of namespacing your objects (views, controllers, etc.). The above example, as such, will not work."
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it is a "Resolver"
looks good, you may want to add nested directories.
additionally, showing how these work in "needs", with the view helper etc.etc. |
|
||
{% highlight sh %} | ||
{% raw %} | ||
{{view 'userview'}} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was having trouble with this naming convention when I stumbled upon this pull request. It seems like it should be {{view 'user'}}, as what you have here didn't work for me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@paperbakwriter09 +1 good catch. Additionally
{{view 'user/show'}}
should be possible for "sub-dirs"
Sweet. Ill take care of these. |
Ok cool. Above commit handles the comments from the past commit. Let me know if there are any other changes - seems to be good for now :) |
|
||
### Views and Templates | ||
|
||
Lets say we were using Ember out of the box with the following view: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh! Minor typo: "Let's", not "Lets".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
@jherdman and @stefanpenner Updated the docs. Sorry for the delay. Loving the feedback! Let me know if this looks good :) |
Adds naming conventions documentation
w00t! |
thanks bro! goes back to sleep |
Creates initial documentation for naming conventions.