fix: Create weakmap before returning weakmap #72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously `state: stateFor('som-state')` would return `undefined` if used in a route, before the computed property was called. This change fixes that.
rwjblue
reviewed
Aug 3, 2017
addon/state-for.js
Outdated
| @@ -24,8 +24,14 @@ let weakMaps = {}; | |||
| * stateFor('state-name').get(this.get('property-name')); | |||
| */ | |||
| export default function stateFor(stateName, propertyName) { | |||
| if (!weakMaps[stateName]) { | |||
There was a problem hiding this comment.
We could restructure it so that in the more common scenario (when the weakmap exists) we only have one object property lookup:
let state = weakMaps[stateName];
if (state === undefined) {
state = weakMaps[stateName] = new WeakMap();
}
|
@knownasilya Looks good to me. I agree w/ @rwjblue about his comment. Also could you add a test case for this? |
|
Thanks @knownasilya! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously
state: stateFor('some-state')would returnundefinedif used in a route, before the computed property was called. This change fixes that.