-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use PnP aware Yarn in CI. #7
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fix.
It also seems like the test passes on my machine with 10.9, and fails with 11.9. Could be my 10.9 environment is hosed?
I suspect the yarn version in windows is old, let me bump it |
@@ -12,6 +12,7 @@ environment: | |||
|
|||
install: | |||
- ps: Install-Product node $env:nodejs_version | |||
- choco install yarn --version=1.13.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's see if this works
Ok that got us 1 step closer
windows escaping FTL, going to move that test into its own file. |
…latform escaping issues
released as v1.0.3 🎉 |
🎉 ! |
@stefanpenner the reason Node 10 worked without this change, but Node 11 required it is due to a change (probably a bug?) in how Node 11 parses See: |
Looks like node folks fixed this in |
No description provided.