This repository has been archived by the owner on Feb 1, 2021. It is now read-only.
Checkout Same Branch in Charts Repo #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevenpall
changed the title
stevenpall
force-pushed
the
checkout-current-branch
branch
from
51b1d3f
to
350bb29
Compare
…ranch being tested
stevenpall
force-pushed
the
checkout-current-branch
branch
from
350bb29
to
37fed32
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This might be too specific to how we structure our releases and charts, but essentially they're all contained in a single repository, and new charts and releases typically get added at the same time via a PR. One issue we've run into is, if the chart a release references isn't currently in the base branch (i.e.
master), the CI checks will fail. This PR checks if the charts repo specified in a release is the same as the repo currently being tested, and if it is, tries to checkout the same branch.If this solution isn't general purpose enough, we could have this be non-default behaviour enabled via an environment variable.