Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include shared library of non owner users #605

Open
wants to merge 5 commits into
base: dev
Choose a base branch
from

Conversation

timvahlbrock
Copy link

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

If the user isn't the owner of the shared zone, photos in the shared zone aren't discovered.

Issue Number: #598

What is the new behavior?

Photos in the shared zone are discovered, regardless of wether the user is owner of the shared zone or not.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@timvahlbrock
Copy link
Author

hey @steilerDev, I totally understand that you're probably still busy and wouldn't have time for a review of this PR or the other one. Could you still enable checks on this PR so I can get it into a state where it is ready to review once you have time for it?

@timvahlbrock timvahlbrock changed the title POC Include shared library of non owner users Jan 18, 2025
@steilerDev
Copy link
Owner

@timvahlbrock can you update your PR so I can get it bundled in the next release?

@timvahlbrock timvahlbrock force-pushed the fix/shared-zone-for-non-owners branch from 743aec0 to 11e759b Compare February 13, 2025 22:45
@timvahlbrock timvahlbrock marked this pull request as ready for review February 13, 2025 22:47
@timvahlbrock
Copy link
Author

FYI: I think I haven't written any tests to test the bug/new functionality yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants