-
-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update node to latest LTS (v22) and other (required) dependency updates #611
Update node to latest LTS (v22) and other (required) dependency updates #611
Conversation
Thanks for the contribution @timvahlbrock - unfortunately tests are still not completing fully - not sure why though :/ |
We urgently need to update the dependencies (but it's such a huge tedious task :D ) After that we can include your other fix as well as a fix to my inability to run the tool. Appreciate you kicking me in the but with your contributions - keep 'em going! |
Okay, will take a look at that.
Yeah, I saw there are quite a few dependabot PRs and some dependencies like node haven't been updated in quite some time. But I get that keeping an existing project up to date gets somewhat tedious and is less exiting than diving into something new. Maybe one could introduce some more automation into dependency management? Dependabot is setup already and this projects seems to have a lot of reliable tests. I haven't seen any integration tests (or e2e, what I mean is 'covering a whole feature/use case') though, which are probably necessary to merge most dependabot PRs automatically.
Yay!
Will do. Got some more ideas on my mind already 😉 |
Test that I just fixed failed because mock-fs seems to expect symlink paths to be abosulte now, but it was relative. Maybe this applies to the other tests as well. |
Mock-fs documentation documents otherwise, so maybe this isn't even a breaking change but a bug that might also occur for other reasons. Might need some more investigation. |
Reproduced and reported this issue: tschaub/mock-fs#414 |
am I seeing this right, all checks have passed - nice! let's get this into nightly 🙏 |
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: #608
What is the new behavior?
Node 22, other updated dependencies
Does this PR introduce a breaking change?
Other information