Adds created_at to trade resource
#345
Conversation
nullstyle
commented
Mar 9, 2017
nullstyle
commented
- db2/history: adds LedgersBySequence to load batch of ledgers based upon the loaded page of trades
- resource: Trade#Populate takes a history.Ledger to populate additional data
- db2/history: adds LedgersBySequence to load batch of ledgers based upon the loaded page of trades - resource: Trade#Populate takes a history.Ledger to populate additional data
| return | ||
| } | ||
|
|
||
| ledgerSequences := make([]interface{}, len(action.Records)) |
There was a problem hiding this comment.
Why not int32 instead of interface{}?
There was a problem hiding this comment.
Because the underlying where call accepts []interface{} and []int32 cannot be casted to []interface{}. You'd have to manually create a populate a new slice within LedgersBySequence. Since LedgersBySequence is effectively an internal only method, I'm fine with having the leniency... you'll still get a good error message if you pass an invalid value, but any numbers and strings work as expected.
|
|
||
| if tt.Assert.NoError(err) { | ||
| tt.Assert.Len(ls, 3) | ||
| } |
There was a problem hiding this comment.
This test could also check if IDs are correct.
| if !found { | ||
| msg := fmt.Sprintf("could not find ledger data for sequence %d", record.LedgerSequence()) | ||
| action.Err = errors.New(msg) | ||
| } |
There was a problem hiding this comment.
good catch, thanks
This commit adds a test that ensures LedgersBySequence returns the correct ledgers
|
Oops, sorry, I wanted to approve this PR. I hope you didn't plan any other changes. |
|
:) no worries, I had finished |
