This repository has been archived by the owner on Aug 21, 2024. It is now read-only.
update getLedgerEntries documentation #614
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview is available here: |
sreuland
reviewed
Oct 16, 2023
api/methods/getLedgerEntries.mdx
Outdated
| - `key`: `<xdr.LedgerKey>` - The key of the ledger entry (serialized in a base64 string). | ||
| - `xdr`: `<xdr.LedgerEntryData>` - The current value of the given ledger entry (serialized in a base64 string). | ||
| - `lastModifiedLedgerSeq`: `<string>` - The ledger number of the last time this entry was updated. | ||
| - `expirationLedgerSeq`: `<number>` - The ledger sequence number after which the ledger entry would expire. This field exists only for ContractCodeEntry and ContractDataEntry ledger entries (optional). |
There was a problem hiding this comment.
should this be a <string>, it has same go json string qualifier on the struct as lastModifiedLedgerSeq which shows <string> type here:
sreuland
approved these changes
Oct 16, 2023
|
Preview is available here: |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What ?
Following up on stellar/stellar-cli#916, this PR updates the corresponding documentation for the getLedgerEntries method.