add defensive checks for not being able to index balance by asset code

stellar · Oct 30, 2024 · 9de6f42 · 9de6f42
1 parent 4a0157c
commit 9de6f42
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 9 deletions.
diff --git a/extension/src/popup/components/account/AssetDetail/index.tsx b/extension/src/popup/components/account/AssetDetail/index.tsx
@@ -81,7 +81,7 @@ export const AssetDetail = ({
     transactionSubmissionSelector,
   );
   const isSuspicious = isAssetSuspicious(
-    balances.balances?.[selectedAsset].blockaidData,
+    balances.balances?.[selectedAsset]?.blockaidData,
   );
 
   const balance = getRawBalance(accountBalances, selectedAsset)!;
@@ -232,7 +232,7 @@ export const AssetDetail = ({
             {isSuspicious && (
               <BlockaidAssetWarning
                 blockaidData={
-                  balances.balances?.[selectedAsset].blockaidData ||
+                  balances.balances?.[selectedAsset]?.blockaidData ||
                   defaultBlockaidScanAssetResult
                 }
               />

diff --git a/extension/src/popup/components/sendPayment/SendAmount/index.tsx b/extension/src/popup/components/sendPayment/SendAmount/index.tsx
@@ -218,7 +218,7 @@ export const SendAmount = ({
     }
     // check for scam asset
     const isSourceAssetScam = isAssetSuspicious(
-      accountBalances.balances?.[asset].blockaidData,
+      accountBalances.balances?.[asset]?.blockaidData,
     );
     if (isSourceAssetScam) {
       setShowBlockedDomainWarning(true);
@@ -228,7 +228,7 @@ export const SendAmount = ({
         domain: assetDomains[values.asset],
         image: assetIcons[values.asset],
         blockaidData:
-          accountBalances.balances?.[asset].blockaidData ||
+          accountBalances.balances?.[asset]?.blockaidData ||
           defaultBlockaidScanAssetResult,
       });
     } else if (isDestAssetScam) {
@@ -239,7 +239,7 @@ export const SendAmount = ({
         domain: assetDomains[values.destinationAsset],
         image: assetIcons[values.destinationAsset],
         blockaidData:
-          accountBalances.balances?.[destinationAsset].blockaidData ||
+          accountBalances.balances?.[destinationAsset]?.blockaidData ||
           defaultBlockaidScanAssetResult,
       });
     } else {
@@ -588,7 +588,7 @@ export const SendAmount = ({
                         assetCode={parsedSourceAsset.code}
                         issuerKey={parsedSourceAsset.issuer}
                         isSuspicious={isAssetSuspicious(
-                          accountBalances.balances?.[asset].blockaidData,
+                          accountBalances.balances?.[asset]?.blockaidData,
                         )}
                       />
                     )}
@@ -601,7 +601,7 @@ export const SendAmount = ({
                           balance={formik.values.amount}
                           icon=""
                           isSuspicious={isAssetSuspicious(
-                            accountBalances.balances?.[asset].blockaidData,
+                            accountBalances.balances?.[asset]?.blockaidData,
                           )}
                         />
                         <PathPayAssetSelect

diff --git a/extension/src/popup/components/sendPayment/SendConfirm/TransactionDetails/index.tsx b/extension/src/popup/components/sendPayment/SendConfirm/TransactionDetails/index.tsx
@@ -320,7 +320,7 @@ export const TransactionDetails = ({
     );
 
   const isSourceAssetSuspicious = isAssetSuspicious(
-    accountBalances.balances?.[asset].blockaidData,
+    accountBalances.balances?.[asset]?.blockaidData,
   );
 
   const isSubmitDisabled = isMemoRequired;
@@ -709,7 +709,7 @@ export const TransactionDetails = ({
                   isMemoRequired={isMemoRequired}
                   blockaidData={
                     (isSourceAssetSuspicious
-                      ? accountBalances.balances?.[asset].blockaidData
+                      ? accountBalances.balances?.[asset]?.blockaidData
                       : accountBalances.balances?.[destinationAsset]
                           ?.blockaidData) || defaultBlockaidScanAssetResult
                   }