-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
redesign the Create New Wallet screens and update tests #1699
Merged
piyalbasu
merged 5 commits into
release/5.26.0
from
feature/redesign-onboarding-recover
Nov 27, 2024
Merged
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
b0b3f89
redesign the Create New Wallet screens and update tests
piyalbasu 8b11c48
rm console.logs
piyalbasu e7a12b2
fix checks in e2e login helpers
piyalbasu a0c3257
updating recovery snapshot. this screen will be redesigned in next PR
piyalbasu cfb5158
fix incorrect mnemonic phrase test
piyalbasu File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file modified
BIN
+7.35 KB
(130%)
...2e-tests/onboarding.test.ts-snapshots/confirm-recovery-page-chromium-darwin.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+70.1 KB
...nsion/e2e-tests/onboarding.test.ts-snapshots/recovery-modal-chromium-darwin.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-21 KB
(54%)
extension/e2e-tests/onboarding.test.ts-snapshots/recovery-page-chromium-darwin.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-5.02 KB
(86%)
extension/e2e-tests/onboarding.test.ts-snapshots/welcome-page-chromium-darwin.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file not shown.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
33 changes: 24 additions & 9 deletions
33
extension/src/popup/components/mnemonicPhrase/CheckButton/styles.scss
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,27 +1,42 @@ | ||
@use "../../../styles/utils.scss" as *; | ||
|
||
.ButtonLabel { | ||
border: 1px solid var(--sds-clr-gray-01); | ||
border-radius: 6.25rem; | ||
border: 1px solid var(--sds-clr-gray-07); | ||
border-radius: #{pxToRem(6px)}; | ||
color: var(--sds-clr-gray-12); | ||
cursor: pointer; | ||
display: inline-block; | ||
font-weight: var(--font-weight-medium); | ||
font-size: 0.875rem; | ||
margin: 3px; | ||
padding: 0.25rem 1rem; | ||
display: flex; | ||
font-weight: var(--sds-fw-semi-bold); | ||
font-size: #{pxToRem(14px)}; | ||
line-height: #{pxToRem(20px)}; | ||
padding: #{pxToRem(6px)} #{pxToRem(10px)}; | ||
text-transform: none; | ||
width: 100%; | ||
|
||
&__number { | ||
color: var(--sds-clr-gray-11); | ||
position: absolute; | ||
width: #{pxToRem(24px)}; | ||
} | ||
&__word { | ||
text-align: center; | ||
width: 100%; | ||
} | ||
} | ||
|
||
.CheckButton { | ||
opacity: 0; | ||
position: absolute; | ||
|
||
&:focus + label { | ||
@include native-like-outline; | ||
} | ||
|
||
&:checked + label { | ||
background: var(--sds-clr-gray-01); | ||
color: white; | ||
background: var(--sds-clr-gray-04); | ||
} | ||
|
||
&__wrapper { | ||
width: 50%; | ||
} | ||
} |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we used to have some logic to redirect users to a specific "You're all set" page on Chrome and a different one on Firefox. We now just have one unified view for both, so this
PinExtension
is now no longer needed