Update metrics.ts #1813
Open
Update metrics.ts #1813
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Better Handling of metrics: If JSON.parse fails (due to invalid JSON), the catch block ensures that the app won’t crash and instead falls back to defaults. If localStorage.getItem returns null, we also handle that by falling back to defaults. We are also explicitly define default values for each property of MetricsData. This ensures the rest of the code can safely use metricsData without checking for undefined. Even if METRICS_DATA is missing, corrupted, or incomplete, metricsData will always have a valid structure matching the MetricsData type.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Better Handling of metrics:
If JSON.parse fails (due to invalid JSON), the catch block ensures that the app won’t crash and instead falls back to defaults. If localStorage.getItem returns null, we also handle that by falling back to defaults. We are also explicitly define default values for each property of MetricsData. This ensures the rest of the code can safely use metricsData without checking for undefined.
Even if METRICS_DATA is missing, corrupted, or incomplete, metricsData will always have a valid structure matching the MetricsData type.