-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Core dependency upgrades #1830
Open
aristidesstaffieri
wants to merge
33
commits into
master
Choose a base branch
from
dependabot/npm_and_yarn/major-a4fa2e6183
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Core dependency upgrades #1830
Changes from 29 commits
Commits
Show all changes
33 commits
Select commit
Hold shift + click to select a range
45ecef5
Bump the major group across 5 directories with 83 updates
dependabot[bot] 9d78969
upgrades all syntax for breaking changes
aristidesstaffieri d8c655a
updates test harness and syntax for new major versions, updates Route…
aristidesstaffieri 514edaf
migrate navigateTo to use v7 API, fix tests for send payment
aristidesstaffieri 429201d
updates account tests for new router model
aristidesstaffieri 4a7f495
updates account creator tests for new router model
aristidesstaffieri 081b57a
updates account history tests for new router model
aristidesstaffieri d68a8e7
updates grant access tests for new router model
aristidesstaffieri fc3d4e1
updates manage assets tests for new router model
aristidesstaffieri e333ae9
updates mnemonic phrase tests for new router model
aristidesstaffieri 71102d5
updates review auth tests for new router model
aristidesstaffieri f95ec60
updates send token payment tests for new router model
aristidesstaffieri 65c7d68
updates sign tx tests for new router model
aristidesstaffieri 5cb10ab
updates swap tests for new router model
aristidesstaffieri a4bc4d0
updates swap unfunded tests for new router model
aristidesstaffieri 6c80d2a
updates operation keyval tests for new router model
aristidesstaffieri 601063f
catches up e2e tests to upstream changes
aristidesstaffieri c9da8f0
bumps node version in CI to 22
aristidesstaffieri 54db544
cleans up imports in ManageAssets test, adds jest dom types to API ts…
aristidesstaffieri df47a2b
temporarily dont fail on eslint failure
aristidesstaffieri 7aa9973
fixes routing logic for nested routes
aristidesstaffieri 184d8f5
disable eslint - temporary
aristidesstaffieri 4b1ef80
fixes nested routing path handling for router v7, disables tests that…
aristidesstaffieri f8f2b7f
updates test ID reference in e2e payment tests
aristidesstaffieri b3ab691
bumps docs node engine to >=22
aristidesstaffieri 25909fe
trigger build to retry docs preview
aristidesstaffieri 79eb390
bumps node version in npm rc for docs
aristidesstaffieri 03bcd79
restores swap index route
aristidesstaffieri 5618e3d
properly handle second level nested routed for settings
aristidesstaffieri 96ef7f5
adds getPathFromRoute to clean up sub routing changes
aristidesstaffieri add3f0c
upgrades all actions to use node version 22
aristidesstaffieri d88f696
removes stray comment from refactor
aristidesstaffieri 9134812
redo eslint, prettier, ts configs to be compatible with new major ver…
aristidesstaffieri File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1 +1 @@ | ||
v21 | ||
v22 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,3 @@ | ||
// Runs in setupFilesAfterEnv hook | ||
// https://jestjs.io/docs/en/configuration#setupfilesafterenv-array | ||
import "@testing-library/jest-dom/extend-expect"; | ||
import "@testing-library/jest-dom"; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -103,7 +103,7 @@ test("Send XLM payment to G address", async ({ page, extensionId }) => { | |
screenshot: "send-payment-details.png", | ||
}); | ||
await expect(page.getByText("Sent XLM")).toBeVisible(); | ||
await expect(page.getByTestId("asset-amount")).toContainText("1 XLM"); | ||
await expect(page.getByTestId("asset-amount")).toContainText("1"); | ||
}); | ||
|
||
test("Send XLM payment to C address", async ({ page, extensionId }) => { | ||
|
@@ -142,7 +142,7 @@ test("Send XLM payment to C address", async ({ page, extensionId }) => { | |
await page.getByText("Details").click({ force: true }); | ||
|
||
await expect(page.getByText("Sent XLM")).toBeVisible(); | ||
await expect(page.getByTestId("asset-amount")).toContainText(".001 XLM"); | ||
await expect(page.getByTestId("asset-amount")).toContainText("0.001"); | ||
|
||
await page.getByTestId("BackButton").click({ force: true }); | ||
await page.getByTestId("BottomNav-link-account").click({ force: true }); | ||
|
@@ -282,7 +282,7 @@ test("Send token payment to C address", async ({ page, extensionId }) => { | |
await page.getByText("Details").click({ force: true }); | ||
|
||
await expect(page.getByText("Sent E2E")).toBeVisible(); | ||
await expect(page.getByTestId("asset-amount")).toContainText(".001 E2E"); | ||
await expect(page.getByTestId("asset-amount")).toContainText("0.001"); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. nice catch on those "asset-amount" string tweaks |
||
}); | ||
test.afterAll(async ({ page, extensionId }) => { | ||
if ( | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
will we need to update the node version in the other GHA's, as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not that I've found, but yeah maybe the build ones would too I can upgrade those to 22.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is done in add3f0c