Fix docs:build #720
Merged
Fix docs:build #720
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hmm, still lands in a failing state but no obvious error in the logs anymore. Still looking into this on the Netlify side, seem ok locally. |
|
@aristidesstaffieri Ah, I see the issue - it's using an old version of Node (12) rather than the one it expects. I'll show you how to upgrade |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks like our docs build was failing because of a bug that's been in terser-webpack-plugin for a while, which is consumed by docusaurus in newer versions.
Details -
facebook/docusaurus#3657
facebook/docusaurus#3515
Solution -
Pin terser-webpack-plugin to the version before this was introduced until it is resolved in future versions by setting a specific version in the top level yarn resolution.