Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

services/horizon: Index out of range for requests with empty url param #1965

Closed
bartekn opened this issue Nov 21, 2019 · 1 comment
Closed

services/horizon: Index out of range for requests with empty url param #1965

bartekn opened this issue Nov 21, 2019 · 1 comment
Assignees
@abuiles
Milestone
Horizon 0.24.0

Comments

@bartekn
Copy link
Contributor

bartekn commented Nov 21, 2019

What version are you using?

Horizon 0.23.1

What did you do?

Request: /accounts//offers?limit=100

What did you expect to see?

No error.

What did you see instead?

runtime.boundsError runtime error: index out of range [0] with length 0
/var/lib/jenkins/jobs/stellar-horizon-public/workspace/services/horizon/internal/actions/helpers.go:612
@bartekn bartekn added this to the Horizon 0.24.0 milestone Nov 21, 2019
abuiles added a commit that referenced this issue Nov 22, 2019
@abuiles
Add regression for #1965.
f6e6639
@abuiles abuiles mentioned this issue Nov 22, 2019
Merged
7 tasks
abuiles added a commit that referenced this issue Nov 25, 2019
@abuiles
services/horizon/internal: Fix index out of range for requests with e…
c027eee 
…mpty named url params. (#1973)

* Add regression for #1965.

* Return early if there are no values for URLParams.

* Add accountID validation on GetAccountOffersHandler

* Use query structs for GetAccountOffersHandler.

* Use GetURLParam in GetParams.
@abuiles
Copy link
Contributor

abuiles commented Nov 25, 2019

Fixed in #1973

@abuiles abuiles closed this as completed Nov 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@abuiles abuiles

Labels
None yet
Projects
None yet
Milestone
Horizon 0.24.0
Development

No branches or pull requests
2 participants
@abuiles @bartekn