Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow setting LOG_FILE_PATH when starting Stellar-Core in captive mode #3438

Closed
bartekn opened this issue Mar 3, 2021 · 2 comments · Fixed by #3463 or #3472
Closed

Allow setting LOG_FILE_PATH when starting Stellar-Core in captive mode #3438

bartekn opened this issue Mar 3, 2021 · 2 comments · Fixed by #3463 or #3472

Comments

@bartekn
Copy link
Contributor

bartekn commented Mar 3, 2021

What problem does your feature solve?

Some users would like to specify where Stellar-Core stores it's log file files because a default /tmp location is not always right.

What would you like to see?

A new config flag that is forwarded to Captive Stellar-Core config (both online and offline modes).

What alternatives are there?

Ideally, Stellar-Core team implements stellar/stellar-core#2943 so there is no need to store log file anywhere (we embed it in Horizon log anyway).

@bartekn
Copy link
Contributor Author

bartekn commented Mar 4, 2021

OK, there was a misunderstanding on my side. We still need a flag so nothing changes in this issue but if the flag is not set we should explicitly set LOG_FILE_PATH="" so the log file is not written anywhere.

@Shaptic
Copy link
Contributor

Shaptic commented Mar 12, 2021

After discussion with ops, here's the agreed-upon strategy for this moving forward:

  • We'll expose an optional parameter, e.g. --captive-core-log-path
  • If this is set, we'll stop logging subservice=core in Horizon and pass the path along to LOG_FILE_PATH
  • If not, we'll continue with the current behavior (log in Horizon and set param to "")

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment