Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a method returning LedgerEntryType of ingest.Change #3889

Closed
bartekn opened this issue Sep 3, 2021 · 3 comments · Fixed by #4158
Closed

Add a method returning LedgerEntryType of ingest.Change #3889

bartekn opened this issue Sep 3, 2021 · 3 comments · Fixed by #4158
Assignees
Labels
ingest New ingestion system small fix

Comments

@bartekn
Copy link
Contributor

bartekn commented Sep 3, 2021

Originally posted by @bartekn in #3887 (comment)

Both can be set but it doesn't matter because the type cannot be changed. We basically want to extract ledger entry type from the change. I guess this should be a method on ingest.Change.

@bartekn bartekn added ingest New ingestion system small fix labels Sep 3, 2021
@erika-sdf erika-sdf self-assigned this Jan 3, 2022
@bartekn
Copy link
Contributor Author

bartekn commented Jan 10, 2022

This issue wasn't about LP type (still cool we have it now!) but Ledger Entry type. Reopening.

@bartekn bartekn reopened this Jan 10, 2022
@erika-sdf
Copy link
Contributor

I think I am a little confused here. Is this different from just referencing change.Type?

@bartekn
Copy link
Contributor Author

bartekn commented Feb 5, 2022

Oh, you are right. Somehow I was thinking that change.Type is LedgerEntryChangeType. Closing.

@bartekn bartekn closed this as completed Feb 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ingest New ingestion system small fix
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants