services/horizon: Add Liquidity Pools to asset stats #3887
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shaptic
reviewed
Sep 3, 2021
Comment on lines
+240
to
+246
| var lpType xdr.LiquidityPoolType | ||
| if pre != nil { | ||
| lpType = pre.Body.Type | ||
| } | ||
| if post != nil { | ||
| lpType = post.Body.Type | ||
| } |
There was a problem hiding this comment.
Sanity check: can both pre and post be set? If so, this block will overwrite lpType.
There was a problem hiding this comment.
Both can be set but it doesn't matter because the type cannot be changed. We basically want to extract ledger entry type from the change. I guess this should be a method on ingest.Change.
tamirms
approved these changes
Sep 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
PR Structure
otherwise).
services/friendbot, orallordocif the changes are broad or impact manypackages.
Thoroughness
.mdfiles, etc... affected by this change). Take a look in the
docsfolder for a given service,like this one.
Release planning
needed with deprecations, added features, breaking changes, and DB schema changes.
semver, or if it's mainly a patch change. The PR is targeted at the next
release branch if it's not a patch change.
What
This commit adds Liquidity Pools to asset stats.
Close #3838.
Why
Assets stats should include all data from all ledger entries so the sum of balances equals the sum of circulating supply of an issued asset.
Known limitations
[TODO or N/A]