txnbuild: more unit tests for FromXDR methods #1558
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ire-and-curses
approved these changes
Aug 2, 2019
| @@ -70,7 +70,7 @@ func memoFromXDR(memo xdr.Memo) (Memo, error) { | |||
| newMemo = MemoHash(value) | |||
| memoCreated = ok | |||
| case xdr.MemoTypeMemoReturn: | |||
| value, ok := memo.GetHash() | |||
| value, ok := memo.GetRetHash() | |||
There was a problem hiding this comment.
It's awesome that these tests found this bug!
| @@ -160,7 +160,7 @@ func (so *SetOptions) handleClearFlagsXDR(flags *xdr.Uint32) { | |||
| if flags != nil { | |||
| for _, f := range []AccountFlag{AuthRequired, AuthRevocable, AuthImmutable} { | |||
| if f&AccountFlag(*flags) != 0 { | |||
| so.SetFlags = append(so.SetFlags, f) | |||
| so.ClearFlags = append(so.ClearFlags, f) | |||
There was a problem hiding this comment.
Another one I'm glad you caught! 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds unit tests for the FromXDR methods implemented by txnbuild operations.
It covers tests for the following operations
The test case for checking if the same xdr is returned if we build and encode will be added when #1448 is fixed.
Closes #1329