txnbuild: Fix manage data value in sep10 challenge #1569
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abuiles
suggested changes
Aug 7, 2019
abuiles
suggested changes
Aug 7, 2019
abuiles
approved these changes
Aug 7, 2019
| if len(randomNonce) != 64 { | ||
| // Encode 48-byte nonce to base64 for a total of 64-bytes | ||
| randomNonceToString := base64.StdEncoding.EncodeToString(randomNonce) | ||
| if len(randomNonceToString) != 64 { |
There was a problem hiding this comment.
NIT: I don't think we need this check here -- we already have an unit test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR uses the correct length of bytes for the manage data value.
As per the protocol
Closes #1562