protocols/horizon: Remove deprecated fee_paid field from Transaction #1828
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tamirms
force-pushed
the
remove-fee-paid
branch
from
8811f0c to
64142ae
Compare
bartekn
approved these changes
Oct 11, 2019
Co-Authored-By: Bartek Nowotarski <bartek@nowotarski.info>
tamirms
force-pushed
the
remove-fee-paid
branch
from
77cc8d0 to
848c2e4
Compare
abuiles
reviewed
Oct 11, 2019
| @@ -417,22 +417,18 @@ type Transaction struct { | |||
| LedgerCloseTime time.Time `json:"created_at"` | |||
| Account string `json:"source_account"` | |||
| AccountSequence string `json:"source_account_sequence"` | |||
| // Action needed in release: horizon-v0.23.0 | |||
| // Action needed in release: horizonclient-v2.0.0 | |||
There was a problem hiding this comment.
Should we open an issue on horizonclient and other SDKs to propagate this update?
tamirms
added a commit
to tamirms/go
that referenced
this pull request
Oct 23, 2019
…saction (stellar#1828)" This reverts commit c4601c0.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
PR Structure
otherwise).
services/friendbot, orallordocif the changes are broad or impact manypackages.
Thoroughness
.mdfiles, etc... affected by this change). Take a look in the
docsfolder for a given service,like this one.
Release planning
needed with deprecations, added features, breaking changes, and DB schema changes.
semver, or if it's mainly a patch change. The PR is targeted at the next
release branch if it's not a patch change.
Summary
fee_paidfield on Transaction resource has been deprecated and is scheduled to be removed in 0.23.0Fixes #1812
Note that we will also need to include this commit in the next client release