Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs for experimental endpoints #1887

Merged
merged 19 commits into from
Oct 30, 2019

Conversation

abuiles
Copy link
Contributor

@abuiles abuiles commented Oct 29, 2019

Add documentation for new and experimental end-points. Refs #1839

@abuiles abuiles force-pushed the docs-for-experimental-endpoints branch from c1b34d1 to 586fa09 Compare October 29, 2019 22:05
@abuiles abuiles marked this pull request as ready for review October 29, 2019 22:14
Copy link
Contributor

@rice2000 rice2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! I left a few comments, but nothing major.

…g-strict-send.md

Co-Authored-By: Justin Rice <justin@stellar.org>
@abuiles abuiles requested a review from rice2000 October 30, 2019 16:42
Copy link
Contributor

@ire-and-curses ire-and-curses left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@abuiles abuiles merged commit a46046b into release-horizon-v0.23.0 Oct 30, 2019
@abuiles abuiles deleted the docs-for-experimental-endpoints branch October 30, 2019 18:00
Copy link
Contributor

@bartekn bartekn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for post-merge comments.

@@ -168,9 +168,9 @@ New payment:

## Testing it out

We now know how to get a stream of transactions to an account. Let's check if our solution actually works and if new payments appear. Let's watch as we send a payment ([`create_account` operation](/developers/guides/concepts/list-of-operations.html#create-account)) from our account to another account.
We now know how to get a stream of transactions to an account. Let's check if our solution actually works and if new payments appear. Let's watch as we send a payment ([`create_account` operation](../../../guides/concepts/list-of-operations.html#create-account)) from our account to another account.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will probably break links when this page is rendered at stellar.org/developers.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bartekn oh, you are right! I'll make a follow up PR and just make the link tp https://stellar.org/developers which is the approach in other docs

}
],
"data": {
"best_friend": "c3Ryb29weQ=="
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😄

@@ -4,6 +4,9 @@ clientData:
laboratoryUrl: https://www.stellar.org/laboratory/#explorer?resource=paths&endpoint=all
---

**Note**: This endpoint will be deprecated, use [/path/strict-receive](./path-finding-strict-receive.html) instead. There are no differences between both endpoints, `/paths` is an alias for `/path/strict-receive`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we going to do this? Worth adding to scheduled breaking changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants