-
Notifications
You must be signed in to change notification settings - Fork 505
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs for experimental endpoints #1887
Docs for experimental endpoints #1887
Conversation
c1b34d1
to
586fa09
Compare
services/horizon/internal/docs/reference/endpoints/path-finding-strict-send.md
Show resolved
Hide resolved
services/horizon/internal/docs/reference/endpoints/path-finding.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! I left a few comments, but nothing major.
services/horizon/internal/docs/reference/endpoints/path-finding-strict-receive.md
Outdated
Show resolved
Hide resolved
services/horizon/internal/docs/reference/endpoints/path-finding-strict-receive.md
Outdated
Show resolved
Hide resolved
services/horizon/internal/docs/reference/endpoints/path-finding-strict-receive.md
Outdated
Show resolved
Hide resolved
services/horizon/internal/docs/reference/endpoints/path-finding-strict-receive.md
Outdated
Show resolved
Hide resolved
services/horizon/internal/docs/reference/endpoints/path-finding-strict-receive.md
Outdated
Show resolved
Hide resolved
services/horizon/internal/docs/reference/endpoints/path-finding-strict-receive.md
Outdated
Show resolved
Hide resolved
services/horizon/internal/docs/reference/endpoints/path-finding-strict-send.md
Show resolved
Hide resolved
…g-strict-receive.md Co-Authored-By: Justin Rice <justin@stellar.org>
…g-strict-receive.md Co-Authored-By: Justin Rice <justin@stellar.org>
…g-strict-receive.md Co-Authored-By: Justin Rice <justin@stellar.org>
…g-strict-send.md Co-Authored-By: Justin Rice <justin@stellar.org>
…g-strict-send.md Co-Authored-By: Justin Rice <justin@stellar.org>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for post-merge comments.
@@ -168,9 +168,9 @@ New payment: | |||
|
|||
## Testing it out | |||
|
|||
We now know how to get a stream of transactions to an account. Let's check if our solution actually works and if new payments appear. Let's watch as we send a payment ([`create_account` operation](/developers/guides/concepts/list-of-operations.html#create-account)) from our account to another account. | |||
We now know how to get a stream of transactions to an account. Let's check if our solution actually works and if new payments appear. Let's watch as we send a payment ([`create_account` operation](../../../guides/concepts/list-of-operations.html#create-account)) from our account to another account. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will probably break links when this page is rendered at stellar.org/developers.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bartekn oh, you are right! I'll make a follow up PR and just make the link tp https://stellar.org/developers which is the approach in other docs
} | ||
], | ||
"data": { | ||
"best_friend": "c3Ryb29weQ==" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😄
@@ -4,6 +4,9 @@ clientData: | |||
laboratoryUrl: https://www.stellar.org/laboratory/#explorer?resource=paths&endpoint=all | |||
--- | |||
|
|||
**Note**: This endpoint will be deprecated, use [/path/strict-receive](./path-finding-strict-receive.html) instead. There are no differences between both endpoints, `/paths` is an alias for `/path/strict-receive`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are we going to do this? Worth adding to scheduled breaking changes.
Add documentation for new and experimental end-points. Refs #1839