services/horizon: Batch Upsert Accounts and Trust Lines #2073
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bartekn
commented
Dec 18, 2019
| @@ -217,7 +219,8 @@ func (p *DatabaseProcessor) ProcessLedger(ctx context.Context, store *pipeline.S | |||
| // Get all transactions | |||
| var transactions []io.LedgerTransaction | |||
| for { | |||
| transaction, err := r.Read() | |||
| var transaction io.LedgerTransaction | |||
| transaction, err = r.Read() | |||
There was a problem hiding this comment.
Looks like staticcheck was upgraded (from 20190621195816-6e04913cbbac to 20191218040434-6f9e13bbec44). This is a fix for shadowed err.
abuiles
reviewed
Dec 18, 2019
| sql := ` | ||
| WITH r AS | ||
| (SELECT | ||
| unnest(?::text[]), /* account_id */ |
abuiles
approved these changes
Dec 18, 2019
services/horizon/internal/expingest/processors/database_processor.go
Outdated
Show resolved
Hide resolved
tamirms
approved these changes
Dec 18, 2019
…sor.go Co-Authored-By: Adolfo Builes <builes.adolfo@gmail.com>
…n/go into batch-upsert-accounts-trust-lines
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
PR Structure
otherwise).
services/friendbot, orallordocif the changes are broad or impact manypackages.
Thoroughness
.mdfiles, etc... affected by this change). Take a look in the
docsfolder for a given service,like this one.
Release planning
needed with deprecations, added features, breaking changes, and DB schema changes.
semver, or if it's mainly a patch change. The PR is targeted at the next
release branch if it's not a patch change.
What
This commit changes
DatabaseProcessorto insert/update (upsert) accounts and trust lines in batches.Why
In #2004 we added
LedgerEntryChangeCachethat aims to decrease number of DB updates: all the changes connected to a single ledger entry are squashed into just one DB query. Even though it gives a nice performance boost when large number of ops change a small number of ledger entries, it turns out this is not enough. When many ledger entries are changed in a new ledger, DB connection round trip time takes significant percentage of time in overall ledger processing time.The SQL query was borrowed from stellar-core.
Known limitations