clients/horizonclient: Support paths/strict-send and paths/strict-receive requests. #2237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ire-and-curses
approved these changes
Feb 6, 2020
Co-Authored-By: Eric Saunders <ire-and-curses@users.noreply.github.com>
abuiles
changed the title
abuiles
changed the title
ire-and-curses
approved these changes
Feb 6, 2020
abuiles
added a commit
that referenced
this pull request
Feb 19, 2020
…eive requests. (#2237) * client/horizonclient: Add support for /paths/strict-send. * Update clients/horizonclient/strict_send_paths_request.go Co-Authored-By: Eric Saunders <ire-and-curses@users.noreply.github.com> * Improve docs for StrictSendPathsRequest. * Add support for paths/strict-receive. * Use strict receive instead of paths in example. Co-authored-by: Eric Saunders <ire-and-curses@users.noreply.github.com>
abuiles
added a commit
that referenced
this pull request
Feb 25, 2020
…eive requests. (#2237) * client/horizonclient: Add support for /paths/strict-send. * Update clients/horizonclient/strict_send_paths_request.go Co-Authored-By: Eric Saunders <ire-and-curses@users.noreply.github.com> * Improve docs for StrictSendPathsRequest. * Add support for paths/strict-receive. * Use strict receive instead of paths in example. Co-authored-by: Eric Saunders <ire-and-curses@users.noreply.github.com>
abuiles
added a commit
that referenced
this pull request
Feb 29, 2020
…eive requests. (#2237) * client/horizonclient: Add support for /paths/strict-send. * Update clients/horizonclient/strict_send_paths_request.go Co-Authored-By: Eric Saunders <ire-and-curses@users.noreply.github.com> * Improve docs for StrictSendPathsRequest. * Add support for paths/strict-receive. * Use strict receive instead of paths in example. Co-authored-by: Eric Saunders <ire-and-curses@users.noreply.github.com>
abuiles
added a commit
that referenced
this pull request
Apr 7, 2020
…eive requests. (#2237) * client/horizonclient: Add support for /paths/strict-send. * Update clients/horizonclient/strict_send_paths_request.go Co-Authored-By: Eric Saunders <ire-and-curses@users.noreply.github.com> * Improve docs for StrictSendPathsRequest. * Add support for paths/strict-receive. * Use strict receive instead of paths in example. Co-authored-by: Eric Saunders <ire-and-curses@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
PR Structure
otherwise).
services/friendbot, orallordocif the changes are broad or impact manypackages.
Thoroughness
.mdfiles, etc... affected by this change). Take a look in the
docsfolder for a given service,like this one.
Release planning
needed with deprecations, added features, breaking changes, and DB schema changes.
semver, or if it's mainly a patch change. The PR is targeted at the next
release branch if it's not a patch change.
What
Extend horizonclient to support request to /paths/strict-send and /paths/strict-receive
This PR also changes
client.Pathsto be an alias forclient.StrictReceivePaths.Why
This is a new end-point in Horizon 1.0
Known limitations
[TODO or N/A]